Hardware requirements checks #5852
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## rc/sirius-patch-2 #5852 +/- ##
=====================================================
- Coverage 80.19% 80.19% -0.01%
=====================================================
Files 708 708
Lines 94094 94094
=====================================================
- Hits 75456 75455 -1
- Misses 13294 13295 +1
Partials 5344 5344 ☔ View full report in Codecov by Sentry. |
ssd04
dismissed stale reviews from AdoAdoAdo, sstanculeanu, and iulianpascalau
via
0db2dc0
There was a problem hiding this comment.
Normal allin test: v1.6.11-dev-config-ace90ef010 -> hardware-requirements-chec-639da41b11
--- Specific errors ---
block hash does not match 6352
wrong nonce in block 2372
miniblocks does not match 0
num miniblocks does not match 0
miniblock hash does not match 0
block bodies does not match 0
receipts hash missmatch 0
/------/
--- Statistics ---
Nr. of all ERRORS: 0
Nr. of all WARNS: 951
Nr. of new ERRORS: 0
Nr. of new WARNS: 1
Nr. of PANICS: 0
/------/
--- ERRORS ---
/------/
--- WARNINGS ---
upcloud-fra-observer-2 :
Warn: wt.Listen()-> connection problem error = connection not open 1
/------/
cmd/node/main.go
Outdated
| @@ -301,3 +307,11 @@ func attachFileLogger(log logger.Logger, flagsConfig *config.ContextFlagsConfig) | |||
|
|
|||
| return fileLogging, nil | |||
| } | |||
|
|
|||
| func checkHardwareRequirements() error { | |||
| if !cpuid.CPU.Supports(cpuid.SSE4, cpuid.SSE42) { | |||
There was a problem hiding this comment.
I do not like having these hardcoded, can we somehow extract them in config.toml ?
| func parseFeatures(features []string) ([]cpuid.FeatureID, error) { | ||
| flags := make([]cpuid.FeatureID, 0) | ||
|
|
||
| for _, cpuFlag := range features { |
There was a problem hiding this comment.
no need for this switch, we have the ParseFeature function
There was a problem hiding this comment.
updated to use ParseFeature func
There was a problem hiding this comment.
Normal allin test: v1.6.11-dev-config-ace90ef010 -> hardware-requirements-chec-728c22bfa4
--- Specific errors ---
block hash does not match 10590
wrong nonce in block 3751
miniblocks does not match 0
num miniblocks does not match 0
miniblock hash does not match 0
block bodies does not match 0
receipts hash missmatch 0
/------/
--- Statistics ---
Nr. of all ERRORS: 17
Nr. of all WARNS: 4310
Nr. of new ERRORS: 17
Nr. of new WARNS: 9
Nr. of PANICS: 0
/------/
--- ERRORS ---
/------/
Reasoning behind the pull request
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?