Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.6.15-dev-config #5917

Merged
merged 6 commits into from Feb 12, 2024
Merged

v1.6.15-dev-config #5917

merged 6 commits into from Feb 12, 2024

Conversation

iulianpascalau
Copy link
Contributor

Reasoning behind the pull request

  • refactored configs

Proposed changes

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@iulianpascalau iulianpascalau marked this pull request as draft February 5, 2024 13:50
Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d5bb384) 80.18% compared to head (eb2e06c) 80.15%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5917      +/-   ##
==========================================
- Coverage   80.18%   80.15%   -0.04%     
==========================================
  Files         709      709              
  Lines       94135    94135              
==========================================
- Hits        75486    75456      -30     
- Misses      13301    13331      +30     
  Partials     5348     5348              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iulianpascalau iulianpascalau marked this pull request as ready for review February 10, 2024 11:22
"stakingvalue": "0",
"delegation": {
"address": "",
"value": "0"
}
}
]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing new line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

}
]
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing new line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

-----BEGIN PRIVATE KEY for 0382c11222db8a15e42e3ff64893df46c7720b439fb2a546462815ac0a8fa3bed99fceae5da9b68524e36f61cc074d09ceafec274c54f182c56a77583f9421f19c777265c43da1d5747304b36f0367cf3e8e5f63f41dad1a4362d9e1997a9e16-----
ZTUxOWQwNzcwZWRlZDhhNTFiMzIwN2M4MWRmMDhjMWZlMWZhMTQ1ZjFmYWQwNDU3
YzI4NzRiNWQzYmY3Y2MwMw==
-----END PRIVATE KEY for 0382c11222db8a15e42e3ff64893df46c7720b439fb2a546462815ac0a8fa3bed99fceae5da9b68524e36f61cc074d09ceafec274c54f182c56a77583f9421f19c777265c43da1d5747304b36f0367cf3e8e5f63f41dad1a4362d9e1997a9e16-----
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing new line

gabi-vuls
gabi-vuls previously approved these changes Feb 12, 2024
@iulianpascalau iulianpascalau merged commit 222e53c into master Feb 12, 2024
7 of 8 checks passed
@iulianpascalau iulianpascalau deleted the v1.6.15-dev-config branch February 12, 2024 13:38
@iulianpascalau iulianpascalau restored the v1.6.15-dev-config branch February 12, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants