New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integration test for deep queries #5935
Conversation
@@ -0,0 +1,206 @@ | |||
//go:build !race | |||
|
|||
// TODO remove build condition above to allow -race -short, after Wasm VM fix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question for review: is this still applicable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, can not be taken out for now :(
|
||
require.Equal(t, snapshotsOfGetState[1], historyOfGetState[1]) | ||
require.Equal(t, snapshotsOfGetNow[1].blockNonce, historyOfGetNow[1].blockNonce) | ||
// This does not seem right! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Though, I think the issue is with the test node, not with the actual implementation of deep queries.
@@ -0,0 +1,206 @@ | |||
//go:build !race | |||
|
|||
// TODO remove build condition above to allow -race -short, after Wasm VM fix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, can not be taken out for now :(
No description provided.