Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scripts for local testnet in multikey mode #5940

Merged
merged 1 commit into from Feb 12, 2024

Conversation

sstanculeanu
Copy link
Contributor

Reasoning behind the pull request

  • with the deprecation of -no-key flag, the local testnets scripts would start the observers as multi key nodes

Proposed changes

  • fix scripts

Testing procedure

  • only scripts changes

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d5bb384) 80.18% compared to head (9de76e0) 80.15%.

Additional details and impacted files
@@                Coverage Diff                @@
##           rc/v1.6.next1    #5940      +/-   ##
=================================================
- Coverage          80.18%   80.15%   -0.03%     
=================================================
  Files                709      709              
  Lines              94135    94135              
=================================================
- Hits               75486    75458      -28     
- Misses             13301    13330      +29     
+ Partials            5348     5347       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sstanculeanu sstanculeanu merged commit d2a027b into rc/v1.6.next1 Feb 12, 2024
9 of 10 checks passed
@sstanculeanu sstanculeanu deleted the fix_local_testnets_scripts_multikey branch February 12, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants