Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unnecessary heartbeat components #5942

Merged
merged 5 commits into from Feb 14, 2024

Conversation

iulianpascalau
Copy link
Contributor

Reasoning behind the pull request

  • low intra-shard peer counters were observed in the logs by grepping after network connection status

Proposed changes

  • removed unnecessary heartbeat components that created confusion regarding the shard membership of a peer

Testing procedure

  • standard system test and observe the connected peer counters

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b5be263) 80.18% compared to head (420251b) 80.21%.

Additional details and impacted files
@@                Coverage Diff                @@
##           rc/v1.6.next1    #5942      +/-   ##
=================================================
+ Coverage          80.18%   80.21%   +0.02%     
=================================================
  Files                709      708       -1     
  Lines              94191    94124      -67     
=================================================
- Hits               75526    75498      -28     
+ Misses             13316    13280      -36     
+ Partials            5349     5346       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iulianpascalau iulianpascalau changed the base branch from master to rc/v1.6.next1 February 12, 2024 07:02
@iulianpascalau iulianpascalau marked this pull request as ready for review February 12, 2024 08:39
Copy link
Collaborator

@gabi-vuls gabi-vuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normal allin test: v1.6.15-dev-config-eb2e06c06d -> fix-low-intra-shard-peers--6dd4a1b386

--- Specific errors ---

block hash does not match 1561
wrong nonce in block 699
miniblocks does not match 0
num miniblocks does not match 0
miniblock hash does not match 0
block bodies does not match 0
receipts hash missmatch 0

/------/

--- Statistics ---

Nr. of all ERRORS: 7
Nr. of all WARNS: 1174
Nr. of new ERRORS: 6
Nr. of new WARNS: 0
Nr. of PANICS: 0

/------/

--- ERRORS ---

/------/

@gabi-vuls gabi-vuls merged commit b5dcb4f into rc/v1.6.next1 Feb 14, 2024
8 checks passed
@gabi-vuls gabi-vuls deleted the fix-low-intra-shard-peers-counters branch February 14, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants