MX-15168: MaxDelegationCap tests #5953
Conversation
# Conflicts: # integrationTests/chainSimulator/staking/delegation_test.go
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## rc/v1.7.0 #5953 +/- ##
=============================================
- Coverage 80.17% 80.17% -0.01%
=============================================
Files 752 752
Lines 97907 97907
=============================================
- Hits 78498 78495 -3
- Misses 14039 14042 +3
Partials 5370 5370 ☔ View full report in Codecov by Sentry. |
| if actionListSize != 0 { | ||
| require.Equal(t, 1, len(auctionList[0].Nodes)) | ||
| require.Equal(t, topUpInAuctionList.String(), auctionList[0].TopUpPerNode) | ||
| require.Equal(t, expectedActionListOwnersSize, len(auctionList)) |
There was a problem hiding this comment.
so, in all other epochs, next after common.StakingV4Step3Flag we have both the expectedNodesInWaitingList and expectedActionListOwnersSize set to 1?
There was a problem hiding this comment.
no, the tests passes because we dont call this in other epochs, fixed to also work for epochs after common.StakingV4Step3Flag
There was a problem hiding this comment.
The way this test is written yes, which is wrong.
We should check exactly which nodes we expect them to be in auction, not making assumptions. If someone with a different config will call these funcs, they would fail, since these conditions are very specific to a single nodes config
There was a problem hiding this comment.
Ok, so now I see that the condition is changed to >= which make more sense to me
| if actionListSize != 0 { | ||
| require.Equal(t, 1, len(auctionList[0].Nodes)) | ||
| require.Equal(t, topUpInAuctionList.String(), auctionList[0].TopUpPerNode) | ||
| require.Equal(t, expectedActionListOwnersSize, len(auctionList)) |
There was a problem hiding this comment.
The way this test is written yes, which is wrong.
We should check exactly which nodes we expect them to be in auction, not making assumptions. If someone with a different config will call these funcs, they would fail, since these conditions are very specific to a single nodes config
Co-authored-by: mariusmihaic <82832880+mariusmihaic@users.noreply.github.com>
Co-authored-by: mariusmihaic <82832880+mariusmihaic@users.noreply.github.com>
mariusmihaic
dismissed stale reviews from iulianpascalau and themself
The base branch was changed.
# Conflicts: # integrationTests/chainSimulator/staking/delegation_test.go
# Conflicts: # integrationTests/chainSimulator/staking/stakingProvider/delegation_test.go
|
ขอบคุณ ฉันจะตรวจสอบอีกทีในภายหลัง แต่ถ้าฉันจำข้อมูลไม่ผิดช่วงเริ่มต้น Node
Bech32 แยกเฝสเป็นหัวข้อย่อย (1/3)หัวข้อ ขั้นต่ำ 10,000 หัวข้อละ
1250อันนี้ไม่น่าจริง น่าจะ25,000-250,000EGLDถ้าผิดผมขอโทษด้วย
ให้ช้อมูลคร่าวไ ตัวเลขประมาณนี้ครับ
… Merged #5953 <#5953> into
rc/v1.7.0.
—
Reply to this email directly, view it on GitHub
<#5953 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AX3E2M7F3ISMNTTEFAQTDBTY654NRAVCNFSM6AAAAABDE74XEGVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJSGU4DQOJVGE3TANA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Reasoning behind the pull request
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?