Deep VM queries: deep-history observer vs. regular observer #6005
Conversation
| return err | ||
| } | ||
|
|
||
| service.rememberQueriedEpoch(blockHeader.GetEpoch()) |
There was a problem hiding this comment.
missing return here?
There was a problem hiding this comment.
Indeed, fixed.
| } | ||
|
|
||
| service.rememberQueriedEpoch(blockHeader.GetEpoch()) | ||
| return err |
There was a problem hiding this comment.
return nil to be more obvious
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## rc/v1.6.next1 #6005 +/- ##
=================================================
- Coverage 80.21% 80.20% -0.01%
=================================================
Files 708 709 +1
Lines 94139 94171 +32
=================================================
+ Hits 75510 75533 +23
- Misses 13280 13289 +9
Partials 5349 5349 ☔ View full report in Codecov by Sentry. |
…ch-snapshotless # Conflicts: # process/smartContract/scQueryService.go
…apshotless Handled vm queries in snapshotless mode
…factor Refactored solution
iulianpascalau
dismissed stale reviews from BeniaminDrasovean and themself
via
ca68006
andreibancioiu
changed the title
There was a problem hiding this comment.
Normal allin test: v1.6.15-dev-config-eb2e06c06d -> vm-queries-remember-epoch-ca68006b99
--- Specific errors ---
block hash does not match 1877
wrong nonce in block 912
miniblocks does not match 0
num miniblocks does not match 0
miniblock hash does not match 0
block bodies does not match 0
receipts hash missmatch 0
/------/
--- Statistics ---
Nr. of all ERRORS: 0
Nr. of all WARNS: 1064
Nr. of new ERRORS: 0
Nr. of new WARNS: 40
Nr. of PANICS: 0
/------/
--- ERRORS ---
/------/
--- WARNINGS ---
/------/
Reasoning behind the pull request
Proposed changes
If observer is started in deep-history mode, perform deep VM queries, using
recreateTrieFromEpoch. Otherwise, rely onrecreateTrie. Most important work is done by #6008.Testing procedure
Log level:
*:DEBUG,process/smartcontract.queryService:TRACE.Inspect logs:
calling RecreateTrie|calling RecreateTrieFromEpoch.Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?