Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Host driver option chain simulator #6061

Merged
merged 5 commits into from Apr 3, 2024

Conversation

miiu96
Copy link
Contributor

@miiu96 miiu96 commented Mar 22, 2024

Reasoning behind the pull request

  • Host driver option chain simulator

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

ShardID: shardID,
RetrialInterval: 100 * time.Millisecond,
HostDriversArgs: hostDriverArgs,
EventNotifierFactoryArgs: &factory.EventNotifierFactoryArgs{},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe fill the args required for notifier?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case no, because we want everyone to use the host driver for the notifier and indexer

@miiu96 miiu96 self-assigned this Mar 27, 2024
Base automatically changed from extend-overridable-configs-files to rc/v1.7.0 March 28, 2024 10:57
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 36.66667% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 78.73%. Comparing base (fd7b7da) to head (06f8e33).

Files Patch % Lines
node/chainSimulator/components/statusComponents.go 45.83% 11 Missing and 2 partials ⚠️
...hainSimulator/components/testOnlyProcessingNode.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           rc/v1.7.0    #6061      +/-   ##
=============================================
- Coverage      78.75%   78.73%   -0.02%     
=============================================
  Files            752      752              
  Lines          98002    98029      +27     
=============================================
+ Hits           77179    77187       +8     
- Misses         15582    15599      +17     
- Partials        5241     5243       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iulianpascalau iulianpascalau merged commit 1bb58ac into rc/v1.7.0 Apr 3, 2024
8 of 10 checks passed
@iulianpascalau iulianpascalau deleted the host-driver-option-chain-simulator branch April 3, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants