New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Host driver option chain simulator #6061
Conversation
ShardID: shardID, | ||
RetrialInterval: 100 * time.Millisecond, | ||
HostDriversArgs: hostDriverArgs, | ||
EventNotifierFactoryArgs: &factory.EventNotifierFactoryArgs{}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe fill the args required for notifier?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case no, because we want everyone to use the host driver for the notifier and indexer
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## rc/v1.7.0 #6061 +/- ##
=============================================
- Coverage 78.75% 78.73% -0.02%
=============================================
Files 752 752
Lines 98002 98029 +27
=============================================
+ Hits 77179 77187 +8
- Misses 15582 15599 +17
- Partials 5241 5243 +2 ☔ View full report in Codecov by Sentry. |
Reasoning behind the pull request
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
feat
branch created?feat
branch merging, do all satellite projects have a proper tag insidego.mod
?