Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chain simulator integration tests multiple packages #6092

Merged
merged 7 commits into from Apr 3, 2024

Conversation

miiu96
Copy link
Contributor

@miiu96 miiu96 commented Apr 2, 2024

Reasoning behind the pull request

  • Splited chain simulator integration tests in multiple packages

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.73%. Comparing base (1bb58ac) to head (46636b6).

Additional details and impacted files
@@              Coverage Diff              @@
##           rc/v1.7.0    #6092      +/-   ##
=============================================
- Coverage      78.73%   78.73%   -0.01%     
=============================================
  Files            752      752              
  Lines          98029    98029              
=============================================
- Hits           77187    77182       -5     
- Misses         15599    15604       +5     
  Partials        5243     5243              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@miiu96 miiu96 self-assigned this Apr 2, 2024
@sstanculeanu sstanculeanu self-requested a review April 3, 2024 06:27
)

var (
ZeroValue = big.NewInt(0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing comments

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@iulianpascalau iulianpascalau merged commit ad0bc8e into rc/v1.7.0 Apr 3, 2024
9 of 10 checks passed
@iulianpascalau iulianpascalau deleted the multiple-packages-integration-tests-cs branch April 3, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants