Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed backwards compatibility problem #6104

Merged
merged 8 commits into from Apr 12, 2024

Conversation

iulianpascalau
Copy link
Contributor

Reasoning behind the pull request

  • fixed backwards compatibility problem

Proposed changes

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

sstanculeanu
sstanculeanu previously approved these changes Apr 3, 2024
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.73%. Comparing base (06f8e33) to head (d21e61d).
Report is 11 commits behind head on rc/v1.7.0.

❗ Current head d21e61d differs from pull request most recent head 1658254. Consider uploading reports for the commit 1658254 to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##           rc/v1.7.0    #6104      +/-   ##
=============================================
- Coverage      78.73%   78.73%   -0.01%     
=============================================
  Files            752      752              
  Lines          98029    98026       -3     
=============================================
- Hits           77187    77179       -8     
- Misses         15599    15603       +4     
- Partials        5243     5244       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sasurobert
sasurobert previously approved these changes Apr 3, 2024
gabi-vuls
gabi-vuls previously approved these changes Apr 4, 2024
Copy link
Collaborator

@gabi-vuls gabi-vuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normal allin test: v1.6.15-dev-config-eb2e06c06d -> fix-backwards-compatibilit-d21e61dd08

--- Specific errors ---

block hash does not match 1327
wrong nonce in block 622
miniblocks does not match 0
num miniblocks does not match 0
miniblock hash does not match 0
block bodies does not match 0
receipts hash missmatch 0

/------/

--- Statistics ---

Nr. of all ERRORS: 0
Nr. of all WARNS: 259
Nr. of new ERRORS: 0
Nr. of new WARNS: 0
Nr. of PANICS: 0

/------/

--- ERRORS ---

/------/

--- WARNINGS ---

/------/

Copy link
Collaborator

@gabi-vuls gabi-vuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normal allin test: v1.6.15-dev-config-eb2e06c06d -> fix-backwards-compatibilit-be60cce475

--- Specific errors ---

block hash does not match 1850
wrong nonce in block 807
miniblocks does not match 0
num miniblocks does not match 0
miniblock hash does not match 0
block bodies does not match 1
receipts hash missmatch 0

/------/

--- Statistics ---

Nr. of all ERRORS: 1
Nr. of all WARNS: 653
Nr. of new ERRORS: 1
Nr. of new WARNS: 228
Nr. of PANICS: 0

/------/

@gabi-vuls gabi-vuls merged commit c332095 into rc/v1.7.0 Apr 12, 2024
8 checks passed
@gabi-vuls gabi-vuls deleted the fix-backwards-compatibility-problem-2024.04.03 branch April 12, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants