Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added block timestamp + scripts update for the round duration #6108

Merged
merged 1 commit into from Apr 11, 2024

Conversation

iulianpascalau
Copy link
Contributor

Reasoning behind the pull request

Proposed changes

Testing procedure

  • standard system test
  • test that the proxy's API endpoint route /network/status/0, /network/status/1 ... /network/status/4294967295 returns the new field called erd_block_timestamp that matches the block's timestamp.

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

Copy link
Collaborator

@gabi-vuls gabi-vuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normal allin test: v1.6.15-dev-config-eb2e06c06d -> add-block-timestamp-in-net-bd41b675cd

--- Specific errors ---

block hash does not match 213
wrong nonce in block 175
miniblocks does not match 0
num miniblocks does not match 0
miniblock hash does not match 0
block bodies does not match 1
receipts hash missmatch 0

/------/

--- Statistics ---

Nr. of all ERRORS: 0
Nr. of all WARNS: 227
Nr. of new ERRORS: 0
Nr. of new WARNS: 0
Nr. of PANICS: 0

/------/

--- ERRORS ---

/------/

--- WARNINGS ---

/------/

@sstanculeanu sstanculeanu merged commit ea7bf27 into rc/v1.7.0 Apr 11, 2024
9 checks passed
@sstanculeanu sstanculeanu deleted the add-block-timestamp-in-network-status branch April 11, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants