Integrate new vm-common: events for "claim developer rewards" #6117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreibancioiu
changed the title
andreibancioiu
commented
Apr 15, 2024
| @@ -224,7 +224,7 @@ func (context *TestContext) initFeeHandlers() { | |||
| RewardsConfigByEpoch: []config.EpochRewardSettings{ | |||
| { | |||
| LeaderPercentage: 0.1, | |||
| DeveloperPercentage: 0.0, | |||
| DeveloperPercentage: 0.3, | |||
There was a problem hiding this comment.
Seems to not have an impact on other tests.
andreibancioiu
commented
Apr 15, 2024
Comment on lines
+34
to
+35
| byte zero32_red[32] = {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0}; | ||
| byte zero32_green[32] = {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0}; |
There was a problem hiding this comment.
Dummy registries (as in red-green-blue).
andreibancioiu
changed the title
iulianpascalau
approved these changes
Apr 15, 2024
andreibancioiu
added
interested:rosetta
interested:api-multiversx-com
area:logs-events-VM
gabi-vuls
approved these changes
Apr 16, 2024
There was a problem hiding this comment.
Normal allin test: v1.6.15-dev-config-eb2e06c06d -> integrate-vm-common-events-5d76ebffdf
--- Specific errors ---
block hash does not match 1750
wrong nonce in block 852
miniblocks does not match 0
num miniblocks does not match 0
miniblock hash does not match 0
block bodies does not match 0
receipts hash missmatch 0
/------/
--- Statistics ---
Nr. of all ERRORS: 0
Nr. of all WARNS: 244
Nr. of new ERRORS: 0
Nr. of new WARNS: 3
Nr. of PANICS: 0
/------/
--- ERRORS ---
/------/
--- WARNINGS ---
/------/
miiu96
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
Previously, the execution of
ClaimDeveloperRewardsdid not emit an event / log entry. Thus, the reason behind a value movement (as a smart contract result) wasn't very explicit.Additionally, when a Parent contract was invoking
ClaimDeveloperRewardson its Children, it was possible for the actual value movement (the Parent receiving the reward) to be completely opaque. For example, see: https://explorer.multiversx.com/transactions?function=claimRewardsAllContractsProposed changes
ClaimDeveloperRewardsTesting procedure
integrationTests/vm/wasm/testdata/developer-rewards/output/developer_rewards.wasm, then follow the same scenario as depicted inintegrationTests/vm/wasm/developerRewards/developerRewards_test.go(invoke a function, then callClaimDeveloperRewards). In the API, look for the new events / logs.Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?