-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate new vm-common: events for "claim developer rewards" #6117
Integrate new vm-common: events for "claim developer rewards" #6117
Conversation
@@ -224,7 +224,7 @@ func (context *TestContext) initFeeHandlers() { | |||
RewardsConfigByEpoch: []config.EpochRewardSettings{ | |||
{ | |||
LeaderPercentage: 0.1, | |||
DeveloperPercentage: 0.0, | |||
DeveloperPercentage: 0.3, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to not have an impact on other tests.
byte zero32_red[32] = {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0}; | ||
byte zero32_green[32] = {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dummy registries (as in red-green-blue).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Normal allin test: v1.6.15-dev-config-eb2e06c06d -> integrate-vm-common-events-5d76ebffdf
--- Specific errors ---
block hash does not match 1750
wrong nonce in block 852
miniblocks does not match 0
num miniblocks does not match 0
miniblock hash does not match 0
block bodies does not match 0
receipts hash missmatch 0
/------/
--- Statistics ---
Nr. of all ERRORS: 0
Nr. of all WARNS: 244
Nr. of new ERRORS: 0
Nr. of new WARNS: 3
Nr. of PANICS: 0
/------/
--- ERRORS ---
/------/
--- WARNINGS ---
/------/
Reasoning behind the pull request
Previously, the execution of
ClaimDeveloperRewards
did not emit an event / log entry. Thus, the reason behind a value movement (as a smart contract result) wasn't very explicit.Additionally, when a Parent contract was invoking
ClaimDeveloperRewards
on its Children, it was possible for the actual value movement (the Parent receiving the reward) to be completely opaque. For example, see: https://explorer.multiversx.com/transactions?function=claimRewardsAllContractsProposed changes
ClaimDeveloperRewards
Testing procedure
integrationTests/vm/wasm/testdata/developer-rewards/output/developer_rewards.wasm
, then follow the same scenario as depicted inintegrationTests/vm/wasm/developerRewards/developerRewards_test.go
(invoke a function, then callClaimDeveloperRewards
). In the API, look for the new events / logs.Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
feat
branch created?feat
branch merging, do all satellite projects have a proper tag insidego.mod
?