Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix genesis flags 2024.04.25 #6141

Merged
merged 2 commits into from Apr 25, 2024
Merged

Fix genesis flags 2024.04.25 #6141

merged 2 commits into from Apr 25, 2024

Conversation

iulianpascalau
Copy link
Contributor

Reasoning behind the pull request

  • import-db did not work on testnet from genesis

Proposed changes

  • added an exception in the genesis flag so the code will execute correctly at genesis time in the staking SC

Testing procedure

  • standard system test
  • import-db on internal system test
  • import-db on testnet
  • import-db on devnet
  • import-db on mainnet

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@iulianpascalau iulianpascalau changed the base branch from master to rc/v1.7.0 April 25, 2024 06:30
gabi-vuls
gabi-vuls previously approved these changes Apr 25, 2024
Copy link
Collaborator

@gabi-vuls gabi-vuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normal allin test: v1.6.15-dev-config-eb2e06c06d -> fix-genesis-flags-2024.04.-bef659207a

--- Specific errors ---

block hash does not match 378
wrong nonce in block 181
miniblocks does not match 0
num miniblocks does not match 0
miniblock hash does not match 0
block bodies does not match 0
receipts hash missmatch 0

/------/

--- Statistics ---

Nr. of all ERRORS: 0
Nr. of all WARNS: 241
Nr. of new ERRORS: 0
Nr. of new WARNS: 0
Nr. of PANICS: 0

/------/

--- ERRORS ---

/------/

--- WARNINGS ---

/------/

@miiu96 miiu96 merged commit 8732346 into rc/v1.7.0 Apr 25, 2024
8 checks passed
@miiu96 miiu96 deleted the fix-genesis-flags-2024.04.25 branch April 25, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants