Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SERVICES-2355] Fix 'where' clause in SumHourly aggregate #1341

Merged
merged 1 commit into from
May 14, 2024
Merged

[SERVICES-2355] Fix 'where' clause in SumHourly aggregate #1341

merged 1 commit into from
May 14, 2024

Conversation

mad2sm0key
Copy link
Contributor

Reasoning

  • the 'where' clause has both OR and AND operators without properly grouping them

Proposed Changes

  • replace key = 'x' OR or key = 'y' operator with key IN('x', 'y') inside where clause for SumHourly timescaledb entity
  • generate migration
  • fix formatting

How to test

N/A

@mad2sm0key
SERVICES-2355: fix where clause in SumHourly aggregate
1cdb681 
- update SumHourly entity
- generate migration
- fix formatting
@mad2sm0key mad2sm0key merged commit 857f8d7 into development May 14, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielailie danielailie danielailie approved these changes

@gabrielmatei gabrielmatei gabrielmatei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mad2sm0key @danielailie @gabrielmatei