-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SERVICES-2346] Tokens trending score #1357
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- compute trending score using volume change, price change and trades change in last 24h
…kens-trending-score
…kens-trending-score
gabrielmatei
approved these changes
May 28, 2024
gabrielmatei
previously approved these changes
May 28, 2024
cfaur09
previously approved these changes
May 28, 2024
…kens-trending-score
…kens-trending-score
…kens-trending-score
The base branch was changed.
claudiulataretu
requested changes
Jun 10, 2024
- added trendingScore computation constants to default.json - updated return type to number for price, volume and trade count change methods - renamed several method
gabrielmatei
approved these changes
Jun 11, 2024
claudiulataretu
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning
trendingScore
field for tokens, to be used for ranking projects based on the price, volume and trade activity in the last 24 hoursProposed Changes
trendingScore
field and resolver to EsdtToken modelminLiquidity
to token filtersHow to test