Move structs from "valuesMulti" and "valuesSingle". Merge input & output #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreibancioiu
commented
May 30, 2024
| if i != len(outputValues)-1 { | ||
| return errors.New("variadic values must be last among output values") | ||
| } | ||
|
|
||
| err = s.deserializeVariadicValues(partsHolder, value) |
There was a problem hiding this comment.
Was dropped by mistake within this series of PRs.
https://github.com/multiversx/mx-sdk-abi-go/blob/main/abi/serializer.go#L147
andreibancioiu
commented
May 30, 2024
| package abi | ||
|
|
||
| // Field is a field in a struct, enum etc. | ||
| type Field struct { |
There was a problem hiding this comment.
Was moved from valuesSingle to its own file.
Most other structs from valuesSingle were moved to their own files (addressValue, boolValue etc.) in previous PRs. Small integers follow in the next PR.
sstanculeanu
previously approved these changes
May 30, 2024
abi/serializer.go
Outdated
| if value.Value == nil { | ||
| return nil | ||
| } | ||
|
|
||
| return s.doSerialize(partsHolder, []any{value.Value}) | ||
| } | ||
|
|
||
| func (s *serializer) serializeInputMultiValue(partsHolder *partsHolder, value InputMultiValue) error { | ||
| func (s *serializer) serializeMultiValue(partsHolder *partsHolder, value *MultiValue) error { | ||
| for _, item := range value.Items { | ||
| err := s.doSerialize(partsHolder, []any{item}) |
There was a problem hiding this comment.
Can't you do return s.doSerialize(partsHolder, value.Items) maybe? Same comment for the other funcs
There was a problem hiding this comment.
Very good point! Refactored.
Tests are passing in the "staging" branch: #8.
sstanculeanu
approved these changes
May 30, 2024
axenteoctavian
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR from a series of many.
No logic change, only refactoring.
See: #5.