Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor enums. Add "fields provider" for heterogeneous enums #16

Merged
merged 2 commits into from
May 30, 2024
Merged

Refactor enums. Add "fields provider" for heterogeneous enums #16

merged 2 commits into from
May 30, 2024

Conversation

andreibancioiu
Copy link
Contributor

@andreibancioiu andreibancioiu commented May 30, 2024 •
edited
Loading

This is a PR from a series of many.

  • EnumValue becomes a SingleValue, as well (the same as the others).
  • We've introduced a fieldsProvider - necessary to return the decoding placeholders for heterogeneous enums.

See: #5.

@andreibancioiu andreibancioiu self-assigned this May 30, 2024
@andreibancioiu andreibancioiu marked this pull request as ready for review May 30, 2024 10:36
@andreibancioiu andreibancioiu merged commit 8426314 into feat/composite May 30, 2024
@andreibancioiu andreibancioiu deleted the composite-enums branch May 30, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sstanculeanu sstanculeanu sstanculeanu approved these changes

@axenteoctavian axenteoctavian axenteoctavian approved these changes

Assignees

@andreibancioiu andreibancioiu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andreibancioiu @sstanculeanu @axenteoctavian