Adjust OptionalValue. Rename files (to correspond to their containing struct) #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreibancioiu
changed the title
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
axenteoctavian
approved these changes
May 9, 2024
iulianpascalau
approved these changes
May 9, 2024
| @@ -28,6 +28,5 @@ type InputOptionalValue struct { | |||
|
|
|||
| // OutputOptionalValue holds an optional value (used for decoding) | |||
| type OutputOptionalValue struct { | |||
There was a problem hiding this comment.
Consider renaming this in the future. "Optional" is irrelevant now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OptionalValue.HasValue(small breaking change). Also seeOptionValue. Checking of value presence should be done as checking for nil.