Use validators file to stake, unstake, etc #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
multiversx_sdk_cli/cli_delegation.py
Outdated
| validators_file = args.validators_file | ||
|
|
||
| if not bls_keys and not validators_file: | ||
| raise errors.BadUsage("No bls keys or validators file provided") |
There was a problem hiding this comment.
Optionally, can be changed to do this, do that: "Either specify the ..., or the ...".
| @@ -4,7 +4,7 @@ build-backend = "hatchling.build" | |||
|
|
|||
| [project] | |||
| name = "multiversx-sdk-cli" | |||
| version = "9.4.1" | |||
| version = "9.5.0" | |||
| @@ -72,7 +73,45 @@ def test_remove_nodes(capsys: Any): | |||
| assert transaction["gasLimit"] == 13645500 | |||
|
|
|||
|
|
|||
| def test_stake_nodes(capsys: Any): | |||
| def test_remove_nodes_with_validators_file(capsys: Any): | |||
Comment on lines
112
to
117
| if args.bls_keys: | ||
| public_keys = self._parse_public_bls_keys(args.bls_keys) | ||
| else: | ||
| validators_file_path = Path(args.validators_file).expanduser() | ||
| validators_file = ValidatorsFile(validators_file_path) | ||
| public_keys = validators_file.load_public_keys() |
There was a problem hiding this comment.
Can it be extracted to _load_validator_public_keys(args) (duplicated below)?
There was a problem hiding this comment.
Extracted the code in a method
Comment on lines
43
to
46
| validator_pem = Path(validator.get("pemFile")).expanduser() | ||
| validator_pem = validator_pem if validator_pem.is_absolute() else self.validators_file_path.parent / validator_pem | ||
|
|
||
| pem_file = ValidatorPEM.from_file(validator_pem) |
There was a problem hiding this comment.
These 3 lines can also be extracted to a separate function e.g. load_validator_pem(path): ValidatorPEM / optional (code exists above, as well).
There was a problem hiding this comment.
extracted in a method
ssd04
reviewed
Feb 7, 2024
andreibancioiu
approved these changes
Feb 7, 2024
ssd04
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a parameter
--validators-filefor staking operations like remove-nodes, stake-nodes, unbond-nodes, unstake-nodes and unjail-nodes.The commands can be used by providing the bls keys using
--bls-keysor the validators file using--validators-file.