Codecs (part 14): abi-based encoding & decoding #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreibancioiu
commented
Jun 13, 2024
| @@ -30,3 +30,22 @@ def decode_top_level(self, data: bytes): | |||
| reader = io.BytesIO(data) | |||
| self.decode_nested(reader) | |||
|
|
|||
| def set_payload(self, value: Any): | |||
There was a problem hiding this comment.
Forgot about this in previous PRs.
andreibancioiu
commented
Jun 13, 2024
| from multiversx_sdk.abi.tuple_value import TupleValue | ||
|
|
||
|
|
||
| def test_set_payload_and_get_payload(): |
There was a problem hiding this comment.
Forgot about tuples in the previous PRs.
popenta
previously approved these changes
Jun 14, 2024
multiversx_sdk/abi/abi_test.py
Outdated
| assert encoded_values == expected_encoded_values | ||
|
|
||
|
|
||
| def test_decode_endpoint_output_parameters_real_world_multisig_get_pending_action_full_info(): |
There was a problem hiding this comment.
could have skipped _real_world_ from the name here and above, but not a big deal :)
There was a problem hiding this comment.
Indeed, removed (remained in the Go test, for the moment).
https://github.com/multiversx/mx-sdk-abi-go/blob/main/abi/serializer_test.go
axenteoctavian
approved these changes
Jun 14, 2024
popenta
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of a series of pull requests.
See: #32.
Changes:
Abicomponent, able to encode & decode endpoint parameters. When the component is initialized, it reads the ABI definitions and prepares value prototypes (typed values) for endpoint parameters & custom types. Then, when appropriate, it clones these prototypes and populates them with native Python values / gets Python values out of them.