V5 (LTS): package whole project source code #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w of secondary importance, exotic, less promoted.
andreibancioiu
commented
Jan 11, 2024
| @@ -1,7 +1,7 @@ | |||
| FROM ubuntu:22.04 | |||
|
|
|||
| # Constants | |||
| ARG BUILDER_NAME="multiversx/sdk-rust-contract-builder:v5.4.1" | |||
| ARG BUILDER_NAME="multiversx/sdk-rust-contract-builder:v5.5.0" | |||
There was a problem hiding this comment.
New minor version. No impact on WASM codehashes.
andreibancioiu
commented
Jan 11, 2024
| @@ -20,7 +20,7 @@ def main(cli_args: List[str]): | |||
| parser.add_argument("--packaged-src", type=str, help="source code packaged in a JSON file") | |||
| parser.add_argument("--contract", type=str) | |||
| parser.add_argument("--output", type=str, default=Path(os.getcwd()) / "output") | |||
| parser.add_argument("--package-whole-project-src", action="store_true", default=False, help="include all project files in *.source.json (default: %(default)s)") | |||
| parser.add_argument("--package-whole-project-src", action="store_true", default=False, help="deprecated parameter, not used anymore") | |||
There was a problem hiding this comment.
It's implicit. Will be removed at a later time.
andreibancioiu
commented
Jan 11, 2024
| ) | ||
|
|
||
| create_packaged_source_code( | ||
| parent_project_folder=project_within_build_folder, | ||
| package_whole_project_src=False, |
There was a problem hiding this comment.
Kept for exotic purposes. Won't be advertised in docs etc.
andreibancioiu
commented
Jan 11, 2024
| @@ -24,7 +24,7 @@ def main(cli_args: List[str]): | |||
|
|
|||
| parser = ArgumentParser() | |||
| parser.add_argument("--project", type=str, required=False, help="source code folder (project)") | |||
| parser.add_argument("--package-whole-project-src", action="store_true", default=False, help="include all project files in *.source.json (default: %(default)s)") | |||
| parser.add_argument("--package-whole-project-src", action="store_true", default=False, help="deprecated parameter, not used anymore") | |||
There was a problem hiding this comment.
It's implicit (always true). Will be removed at a later time.
andreibancioiu
commented
Jan 11, 2024
| @@ -61,8 +61,6 @@ def get_source_code_files( | |||
| def _is_source_code_file(path: Path) -> bool: | |||
| if path.suffix == ".rs": | |||
| return True | |||
| if path.parent.name == "meta" and path.name == "Cargo.lock": | |||
There was a problem hiding this comment.
Very important change. Some projects aren't Cargo workspaces, and this Cargo lock file should be included in the packaged source code.
bogdan-rosianu
approved these changes
Jan 11, 2024
ovidiuolteanu
approved these changes
Jan 11, 2024
andreibancioiu
changed the title
popenta
approved these changes
Jan 11, 2024
This was referenced Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
meta/Cargo.lockanymore - they are extremely important if the project is not a Cargo workspace.*.source.jsonnow contains the whole packaged source code.*.partial.source.jsoncontains only the source code of the contract to be built and the source code of its local dependencies - it should never be used (suffers from incompleteness) . Exists for exotic use-cases, if any.This will be promoted to v6, as well.
Also see: https://discord.com/channels/1045353153073258557/1194657415690473482