Update versions #60
Closed
Update versions #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @michavie, Thank you 🙏 🎉 I think we'd like to have this as |
| ARG BUILDER_NAME="multiversx/sdk-rust-contract-builder:v6.1.2" | ||
| ARG VERSION_RUST="nightly-2023-12-11" | ||
| ARG BUILDER_NAME="multiversx/sdk-rust-contract-builder:v6.2.0" | ||
| ARG VERSION_RUST="stable" |
There was a problem hiding this comment.
We'll also use an actual, fixed version here.
| @@ -1,12 +1,12 @@ | |||
| FROM ubuntu:22.04 | |||
|
|
|||
| # Constants | |||
| ARG BUILDER_NAME="multiversx/sdk-rust-contract-builder:v6.1.2" | |||
| ARG VERSION_RUST="nightly-2023-12-11" | |||
| ARG BUILDER_NAME="multiversx/sdk-rust-contract-builder:v6.2.0" | |||
There was a problem hiding this comment.
Most probably, we want this to be v7.0.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds using >
0.50.2ofmx-sdk-rsfail due to not having diagnostics attributes available in nightly. However, it is available in the latest rust stable release: https://blog.rust-lang.org/2024/05/02/Rust-1.78.0.html#diagnostic-attributesThis PR is mostly a reminder to update versions to the latest & stable – feel free to merge or push further changes.