Merge pull request mbrevoort#9 from liorsion/master

Code fails to select with jquery 1.5 on firefox
mulukavinaymurthy · May 30, 2011 · 7d4163c · 7d4163c
2 parents 15d0da6 + bfd1b6d
commit 7d4163c
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 7 deletions.
diff --git a/jquery.facebook.multifriend.select.css b/jquery.facebook.multifriend.select.css
@@ -69,7 +69,8 @@ limitations under the License.
 
 #jfmfs-friend-selector {
     width:725px;   
-    height:376px;                            
+    height:376px;
+    overflow-y:hidden;                            
 }
 
 #jfmfs-inner-header {

diff --git a/jquery.facebook.multifriend.select.js b/jquery.facebook.multifriend.select.js
@@ -149,7 +149,7 @@
                 // already been selected, if so, just return
                 if(!$(this).hasClass("selected") && 
                     maxSelectedEnabled() &&
-                    $(".jfmfs-friend.selected").size() >= settings.max_selected &&
+                    $(".jfmfs-friend.selected").length >= settings.max_selected &&
                     settings.max_selected != 1) {
                         return;
                     }
@@ -176,7 +176,7 @@
                             for(var i=start; i<=end; i++) {
                                 var aFriend = $( all_friends[i] );
                                 if(!aFriend.hasClass("hide-non-selected") && !aFriend.hasClass("hide-filtered")) {
-                                    if( maxSelectedEnabled() && $(".jfmfs-friend.selected").size() < settings.max_selected ) {
+                                    if( maxSelectedEnabled() && $(".jfmfs-friend.selected").length < settings.max_selected ) {
                                         $( all_friends[i] ).addClass("selected");                                        
                                     }
                                 }
@@ -313,7 +313,7 @@
         };
 
         var selectedCount = function() {
-            return $(".jfmfs-friend.selected").size();
+            return $(".jfmfs-friend.selected").length;
         };
 
         var maxSelectedEnabled = function () {

diff --git a/jquery.facebook.multifriend.select.min.js b/jquery.facebook.multifriend.select.min.js