Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give metadata about events to widgets. #272

Closed
wants to merge 2 commits into from
Closed

Give metadata about events to widgets. #272

wants to merge 2 commits into from

Conversation

mum4k
Copy link
Owner

@mum4k mum4k commented Nov 25, 2020

Widgets now receive an additional argument together with keyboard and mouse events that provides metadata about the event. Initially it indicates if the widget's container was focused at the time of the event.

@coveralls
Copy link

coveralls commented Nov 25, 2020

Pull Request Test Coverage Report for Build 1944

  • 53 of 59 (89.83%) changed or added relevant lines in 12 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.001%) to 91.004%

Changes Missing Coverage Covered Lines Changed/Added Lines %
widgets/barchart/barchart.go 0 2 0.0%
widgets/heatmap/heatmap.go 0 2 0.0%
widgets/sparkline/sparkline.go 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
private/fakewidget/fakewidget.go 1 86.05%
Totals Coverage Status
Change from base Build 1941: -0.001%
Covered Lines: 8083
Relevant Lines: 8882

💛 - Coveralls

@mum4k
Copy link
Owner Author

mum4k commented Nov 25, 2020

After further consideration, this isn't really necessary. The use case I had in mind can be achieved without this metadata and I don't know of another. The lack of use case doesn't justify the breaking API change which should be avoided until really necessary.

@mum4k mum4k closed this Nov 25, 2020
@mum4k mum4k deleted the 243-event-meta branch November 25, 2020 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants