[5/5] Implementing the text widget. #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 25
💛 - Coveralls |
Pull Request Test Coverage Report for Build 57
💛 - Coveralls |
chipmunkie
approved these changes
May 26, 2018
widgets/text/text.go
Outdated
| t.givenWOpts = newGivenWOpts() | ||
| t.scroll = newScrollTracker(t.opts) | ||
| t.lastWidth = 0 | ||
| t.newText = true |
There was a problem hiding this comment.
Should this be true if there is no content and has been reset (reset kind of gives the impression on new text was added yet).
There was a problem hiding this comment.
Good point, renamed newText to contentChanged.
| break | ||
| } | ||
|
|
||
| if r == '\n' { |
There was a problem hiding this comment.
Do we actually need this statement?
There was a problem hiding this comment.
Yes, otherwise we print out the newline rune below which adds an empty line of text.
Note - I am not happy with this function as it is in this pull request. I have refactored it into something hopefully easier to understand in the next one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4