Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for full-width runes in the remaining code. #39

Merged
merged 8 commits into from Jun 13, 2018
Merged

Support for full-width runes in the remaining code. #39

merged 8 commits into from Jun 13, 2018

Conversation

mum4k
Copy link
Owner

@mum4k mum4k commented May 27, 2018

  • Support alignment of text with full-width runes.
  • Generalise text trimming logic.
  • Gauge widget now supports full-width runes.
  • Skip over partial cells when diffing fake terminals.

Fixes #37

mum4k added 5 commits May 27, 2018 19:27
@mum4k
Faketerm and diff on it supports partial cells.
9786171 
Don't print out partial cells (cells that don't really exist since the
previous cell contains a full-width rune).
@mum4k
Alignment now supports full-width runes.
c148d8c
@mum4k
Generalized text trimming logic.
8a1bb34 
So it can be reused in widgets.

Also adding some missing default values for options.
@mum4k
Gauge widget now supports full-width runes.
945b48f
@mum4k
Updating the gaugedemo image.
e5ca702 
It contains full-width runes.
@mum4k mum4k requested a review from chipmunkie May 27, 2018 18:35
@mum4k mum4k self-assigned this May 27, 2018
@coveralls
Copy link

coveralls commented May 27, 2018 •
edited

Pull Request Test Coverage Report for Build 101

  • 64 of 68 (94.12%) changed or added relevant lines in 5 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.1%) to 84.942%
Changes Missing Coverage Covered Lines Changed/Added Lines %
widgets/gauge/gauge.go 31 35 88.57%
Files with Coverage Reduction New Missed Lines %
widgets/gauge/gauge.go 1 82.97%
draw/text.go 1 96.43%
Totals Coverage Status
Change from base Build 88: -0.1%
Covered Lines: 1918
Relevant Lines: 2258
💛 - Coveralls

@mum4k mum4k changed the base branch from text-widget/6/wide-runes to master June 4, 2018 16:43
chipmunkie
chipmunkie approved these changes Jun 12, 2018
View reviewed changes
draw/text.go Outdated
b.WriteRune(r)
case om == OverrunModeTrim:
// Only write the rune if it still fits, i.e. don't cut
// full-width runes in halt.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/halt/half

@mum4k mum4k merged commit 0fb44ec into master Jun 13, 2018
@mum4k mum4k deleted the bugfix-rune-count branch June 13, 2018 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chipmunkie chipmunkie chipmunkie approved these changes

Assignees

@mum4k mum4k

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mum4k @coveralls @chipmunkie @googlebot