Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thread safe widgets #98

Merged
merged 3 commits into from Jan 27, 2019
Merged

Thread safe widgets #98

merged 3 commits into from Jan 27, 2019

Conversation

mum4k
Copy link
Owner

@mum4k mum4k commented Jan 27, 2019

Fixes #63

@mum4k
Fixing racy behavior between Options and Draw.
8968704 
This applies to widgets whose Options depend on user data.
Documenting this in the docs and on API and protecting against this
condition in the affected widgets.
@mum4k
Updating CHANGELOG.
8f6c2e5
@coveralls
Copy link

coveralls commented Jan 27, 2019 •
edited

Pull Request Test Coverage Report for Build 642

  • 32 of 40 (80.0%) changed or added relevant lines in 6 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.1%) to 89.124%
Changes Missing Coverage Covered Lines Changed/Added Lines %
widgets/barchart/barchart.go 5 7 71.43%
widgets/gauge/gauge.go 5 7 71.43%
widgets/linechart/linechart.go 13 15 86.67%
widgets/sparkline/sparkline.go 5 7 71.43%
Files with Coverage Reduction New Missed Lines %
container/draw.go 1 78.0%
widgets/linechart/linechart.go 2 79.77%
Totals Coverage Status
Change from base Build 638: -0.1%
Covered Lines: 3999
Relevant Lines: 4487
💛 - Coveralls

@mum4k mum4k merged commit c80cb19 into devel Jan 27, 2019
@mum4k mum4k deleted the thread-safe-widgets branch January 27, 2019 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mum4k @coveralls @googlebot