Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't try to close the TCP listener, since it was already closed when the TLS listener was closed #43

Closed
wants to merge 1 commit into from
Closed

Don't try to close the TCP listener, since it was already closed when the TLS listener was closed #43

wants to merge 1 commit into from

Conversation

olabiniV2
Copy link
Contributor

@olabiniV2 olabiniV2 commented Dec 20, 2019 •
edited by davidebeatrici
Loading

Superseded by #45.

@davidebeatrici
Copy link
Member

There are unrelated changes, could you split them in different commits, please?

I can also do that, if you prefer.

@olabiniV2
Copy link
Contributor Author

Sorry about that - I'll submit a new pull request.
My environment automatically reformats after gofmt guidelines, and since the grumble code base in some cases diverges, that's why the extra changes happened.

@olabiniV2 olabiniV2 closed this Dec 20, 2019
@davidebeatrici
Copy link
Member

No problem.

You could also keep this pull request and force-push.

@davidebeatrici davidebeatrici changed the title Don't try to close the TCP listener, since it was already closed when… Don't try to close the TCP listener, since it was already closed when the TLS listener was closed Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@olabiniV2 @davidebeatrici