Skip to content

Commit

Permalink
Explicitly remove file permissions for settings and DB
Browse files Browse the repository at this point in the history
  • Loading branch information
thorvald committed May 27, 2011
1 parent 67ed381 commit 5632c35
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 0 deletions.
5 changes: 5 additions & 0 deletions src/mumble/Database.cpp
Expand Up @@ -94,6 +94,11 @@ Database::Database() {
qWarning("Database: Database is read-only");
}

{
QFile f(db.databaseName());
f.setPermissions(f.permissions() & ~(QFile::ReadGroup | QFile::WriteGroup | QFile::ExeGroup | QFile::ReadOther | QFile::WriteOther | QFile::ExeOther));
}

QSqlQuery query;

query.exec(QLatin1String("CREATE TABLE IF NOT EXISTS `servers` (`id` INTEGER PRIMARY KEY AUTOINCREMENT, `name` TEXT, `hostname` TEXT, `port` INTEGER DEFAULT " MUMTEXT(DEFAULT_MUMBLE_PORT) ", `username` TEXT, `password` TEXT)"));
Expand Down
11 changes: 11 additions & 0 deletions src/mumble/Settings.cpp
Expand Up @@ -716,6 +716,17 @@ void OverlaySettings::save() {
void OverlaySettings::save(QSettings* settings_ptr) {
OverlaySettings def;

settings_ptr->setValue(QLatin1String("version"), QLatin1String(MUMTEXT(MUMBLE_VERSION_STRING)));
settings_ptr->sync();

#if defined(Q_OS_WIN) || defined(Q_OS_MAC)
if (settings_ptr->format() == QSettings::IniFormat)
#endif
{
QFile f(settings_ptr->fileName());
f.setPermissions(f.permissions() & ~(QFile::ReadGroup | QFile::WriteGroup | QFile::ExeGroup | QFile::ReadOther | QFile::WriteOther | QFile::ExeOther));
}

SAVELOAD(bEnable, "enable");

SAVELOAD(osShow, "show");
Expand Down

0 comments on commit 5632c35

Please sign in to comment.