Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incompatibility with Mumble/WoW (Mavericks) #1010

Closed
mumble-voip opened this issue Jul 3, 2013 · 17 comments
Closed

Incompatibility with Mumble/WoW (Mavericks) #1010

mumble-voip opened this issue Jul 3, 2013 · 17 comments
Assignees
@mkrautz
Labels
macOS overlay
Milestone
1.3.0

Comments

@mumble-voip
Copy link
Collaborator

Mac OSX (Mavericks Developer Preview 2)
World of Warcraft Version 5.3.0 (17128) Release x64 Post Patch 7/2/2013
Mumble 1.2.4

When Mumble is running, now WoW quits. Here is Blizzard's diagnostic ID: 63A85162-5EDB-43DE-89CE-8D4F67676D18. I can't find any logs to provide details. Blizzard's error reporter only provided that reference number.

Mumble/WoW worked fine before the 7/2 rolling restarts.

Reporting to WoW as well, but wanted to let you know.

I do not know, yet, if this is a Mountain Lion issue or a Mavericks one.

Interesting note. If you launch WoW before Mumble, everything works fine. If you launch Mumble before WoW, WoW crashes.

This ticket has been migrated from sourceforge. It is thus missing some details like original creator etc.
The original is at https://sourceforge.net/p/mumble/bugs/1010/ .
@mkrautz
Copy link
Contributor

mkrautz commented Jul 3, 2013

There is another bug report that resizing the WoW window causes crashes when you run with the overlay enabled using Mumble 1.2.4. Maybe that's related?

@mumble-voip
Copy link
Collaborator Author

Tested - Yes. De-selecting "Enable Overlay" results in WOW being launchable after Mumble is launched.

Workaround could be to launch WoW first.

@mkrautz
Copy link
Contributor

mkrautz commented Jul 3, 2013

That's a workaround for the crash, but the overlay won't work for WoW if it's launched before Mumble... :)

@mumble-voip
Copy link
Collaborator Author

Oh, that's a delightful dilemma. Happy to be a guinea pig, if you need one.

@cdaveb
Copy link

cdaveb commented Dec 8, 2013

I’m also experiencing this issue with the released version of Mavericks (10.9). The only thing that fixes it is disabling the overlay. This is the report in the console generated when trying to launch WoW when the overlay is enabled:

12/7/13 9:42:37.016 PM Blizzard Error[31184]: Performance: Please update this scripting addition to supply a value for ThreadSafe for each event handler: "/Library/ScriptingAdditions/MumbleOverlay.osax"

I got this same type of error when trying to launch Firefox so I believe it probably affects most if not all Mac apps which support the overlay. The error was:

12/7/13 9:53:08.234 PM osascript[32484]: Performance: Please update this scripting addition to supply a value for ThreadSafe for each event handler: "/Library/ScriptingAdditions/MumbleOverlay.osax"

@ghost ghost assigned mkrautz Dec 8, 2013
@onetimebsanders
Copy link

This is still not working with 1.2.5. Please can we fix this, having to to tab to see who's still using voice activation and has it set too high is the worst.

Blizzard error: E3EE5730-C37F-4AF6-9F52-28032FC6477E

@mkrautz
Copy link
Contributor

mkrautz commented Feb 6, 2014

We're obviously not happy that things like these are not yet fixed. We just don't have infinite resources on or small development team (with only one Mac guy -- me, and I do a lot of other stuff as well) we're pretty resource constrained.

However, I'll see if I can get this fixed soon. It's too bad that these things sit here for half a year.

Sorry.

@nrw2001
Copy link

nrw2001 commented Sep 3, 2014

is there any progress on this issue? if not is there anything that i may be able to do to help? little to no actual coding exp but ill do whatever i can to help. i miss my overlay for wow.

@mortalcoil
Copy link

yeah still not working for me in fullscreen or windowed mode a year without the feature really hurts. If you need beta testers i am happy to help

@mkrautz
Copy link
Contributor

mkrautz commented Feb 5, 2015

This should be fixed in Git. I will spin out a new snapshot as soon as possible.

@nrw2001
Copy link

nrw2001 commented Feb 5, 2015

building current git. will test and report.

edit: getting an error. guess ill have to wait for the new snapshot. >.<

@mkrautz
Copy link
Contributor

mkrautz commented Feb 6, 2015

Yeah, seems like the build didn't go through -- sorry. I will check on it later today.

@nrw2001
Copy link

nrw2001 commented Feb 8, 2015

perfect! so happy to have this back!

@habovh
Copy link

habovh commented Mar 4, 2015

Does the last snapshot include the bug fix? I just tested out on 1.3.0540gedd5509~snapshot, still causing crashes on wow launch if overlay is activated...

@nrw2001
Copy link

nrw2001 commented Mar 4, 2015

Yes. The snapshot fixed the issue. If you are still having crashes. UN install the OVERLAY from within the mumble settings and then install the overlay from within mumble settings. The update does not auto update the overlay files. Hope that fixes it for you.

@habovh
Copy link

habovh commented Mar 4, 2015

Ok, I can confirm that enabling the overlay does not crash wow anymore. However, I have no overlay at all, despite resetting to default settings...

@mkrautz
Copy link
Contributor

mkrautz commented Mar 4, 2015

@toborrow See #1561

mkrautz added a commit to mkrautz/mumble that referenced this issue Jun 19, 2016
@mkrautz
overlay_gl: unmask framebuffer color components in drawContext().
b16e5a1 
World of Warcraft masks all colors via glColorMaskIndexedEXT(0, 0, 0, 0, 0)
before we draw our overlay.

This broke overlay rendering on OS X when shadow quality was set
to anything greater than low.

This commit ensures that we allow drawing of colors to the main
framebuffer -- so we can draw the overlay properly.

Fixes mumble-voip#1010
Fixes mumble-voip#1561
@mkrautz mkrautz mentioned this issue Jun 19, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkrautz mkrautz

Labels
macOS overlay
Projects
None yet
Milestone
1.3.0
Development

No branches or pull requests
6 participants
@mkrautz @habovh @mortalcoil @cdaveb @onetimebsanders @nrw2001