HTMLFilter's plain text does not preserve whitespace

[mkrautz]

/cc @LuaMilkshake

Per #2069 (comment)

Because we use QString::simplified(), whitespace at the beginning and end of a plain text message (a text message sent on a server with allowhtml=false) will be dropped by the HTMLFilter class.

Also, multiple whitespace characters will be converted into a single space character.

[warrenspe]

This has been the bane of my team's usage of mumble - whenever we're sending code (python, in particular) across to one another we need to resort to skype as mumble renders it unusable without fixing a bunch of truncated whitespace

[Krzmbrzl]

@warrenspe with Mumble 1.4 or newer we have Markdown support. Just paste your code in code markup and it should be sent as-is.
Note that there won't be any syntax highlighting or the like - but it should resolve the whitespace issue

[warrenspe]

Hey @Krzmbrzl

Thanks for the reply! Does markdown function when allowhtml=false? I've tried it with triple backticks but it seems to come through verbatim.

If not, I can always reconfigure to turn html back on; but it is a bit unfortunate to need to remember to use backticks. Is a workaround, at least though

Thanks!

[Krzmbrzl]

No the Markdown gets converted to HTML before sending, so by disabling HTML, you also disable Markdown

[warrenspe]

Hey @Krzmbrzl ,

One last question for you - I've reenabled html on my murmur server, but I seem to having some trouble getting markdown working; I've tried the usual culprits for code blocks (4 space indentation and triple backticks) but neither seem to generate a code block for me. Would you be able to point me in the right direction on how murmur is expecting a code block to be formatted?

[Krzmbrzl]

The server does not expect anything. This feature is entirely client-side. Is the client you are using >= 1.4?

[warrenspe]

Ah, that explains that. I hadn't updated the client to 1.4 yet, sorry!