Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for external images (proxying) #3597

Open
azlux opened this issue Feb 12, 2019 · 1 comment
Open

Support for external images (proxying) #3597

azlux opened this issue Feb 12, 2019 · 1 comment
Labels
feature-request This issue or PR deals with a new feature

Comments

@azlux
Copy link

azlux commented Feb 12, 2019

Hi all,
I was discussing on the IRC about the rollback of the "support for external image" implementation.

I open this ticket to discuss about the implementation the software "Thelounge" use. You can check the option of this software here from prefetchStorage to fileUpload.

Based on the IRC discussion and the implementation thelounge have done. Here the idea to implement an image support on mumble :
External Image

  1. The server load thumbnails and site descriptions from URLs posted in channels
  2. The server load thumbnails and site descriptions from URLs posted in private messages (optional)
  3. The server store and proxy prefetched images and thumbnails on the filesystem rather than directly display the content at the original URLs with the client (You protect client IP, only the server is fetching the url), the client ask the server for the data. No tentative the fetch directly the URL.

Internal Image:
4. Allow uploading files (limited by the config) to the server hosting Mumble. (and post the url) the client prefetch will directly get the image because it's the same domain as the server.

You make an amazing job with mumble.
Best regards
Azlux

@Kissaki Kissaki added the feature-request This issue or PR deals with a new feature label Mar 22, 2019
@azlux azlux mentioned this issue May 29, 2019
@davidebeatrici davidebeatrici added this to the 1.4.0 milestone May 30, 2019
@Kissaki Kissaki changed the title Support for images Support for external images (proxying) Sep 1, 2019
@Kissaki Kissaki added this to Accepted in Feature Requests Sep 1, 2019
@wabash1
Copy link
Contributor

wabash1 commented Feb 29, 2020

Please add the option in the murmur config to not proxy the server to protect the client and allow the client to fetch the images even though this will expose the IP, in my particular situation bandwidth can be expensive.

@Kissaki Kissaki removed this from the 1.4.0 milestone Mar 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request This issue or PR deals with a new feature
Projects
Development

No branches or pull requests

4 participants