Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Text-To-Speech by default #4627

Merged
merged 1 commit into from Dec 18, 2020
Merged

Conversation

peylight
Copy link
Contributor

Disable Text-To-Speech by default As requested in #4626

Copy link
Member

@Krzmbrzl Krzmbrzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ensure that your commit message meets our commit guidelines.

In this case I'd suggest changing it to something like

FEAT(client): Disable TTS by default

Fixes #4626

Furthermore it seems like the author details don't seem to match up with your GitHub account. If this is intended, then that's not a problem though. Just wanted to bring it to your attention in case it was not intended :)

@Krzmbrzl
Copy link
Member

The authorship still doesn't seem to be quite right. You might want to have a look at https://stackoverflow.com/questions/3042437/how-to-change-the-commit-author-for-one-specific-commit

Let me know if I should go ahead and merge anyways. That'd be no problem from my side ☝️

@Krzmbrzl Krzmbrzl linked an issue Dec 15, 2020 that may be closed by this pull request
@Krzmbrzl
Copy link
Member

I'll just assume that you're fine with how the commit is atm ☝️

@Krzmbrzl Krzmbrzl merged commit 675c046 into mumble-voip:master Dec 18, 2020
@Krzmbrzl
Copy link
Member

Thank you for your contribution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable Text-To-Speech by default
2 participants