FEAT(client, ui): separate ipv4 and ipv6 in ServerItem tooltip #5714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Krzmbrzl
requested changes
Jun 3, 2022
Krzmbrzl
added
client
ui
feature-request
inodanus
force-pushed
the
separate-ipv4-and-ipv6
branch
from
026ee81
to
f0a155f
Compare
|
Just for your information: The commits seem to have been associated with emails that are not connected to your GitHub accounts. This doesn't bother us, but I wanted to make you aware that right now the commits don't attribute authorship to your respective GitHub accounts ☝️ |
|
Do you happen to have a clang-format 10 installation at hand? If so, please run it on the source files you edited to bring them into the proper formatting. If not, let me know and I can do that for you. |
The "Addresses" field in the ServerItem tooltip shows both ipv4 and ipv6 addresses. The order of addresses in this field is not determined. In the wild it is randomized. As discussed in mumble-voip#5696 it is better to implement a concrete ordering to prevent user confusion. To further improve the readability of the addresses we split the addresses field in two fields called "IPv4 address" and "IPv6 address". The ipv4 address is now always shown above the ipv6 address. Implements mumble-voip#5696 Co-Authored-By: Thomas Pawelek <thomas.pawelek@stud.uni-hannover.de>
inodanus
force-pushed
the
separate-ipv4-and-ipv6
branch
from
f0a155f
to
4d3f63a
Compare
|
The code should now be correctly formatted with clang-format 10. |
Krzmbrzl
approved these changes
Jun 5, 2022
|
Thank you for your contribution 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Addresses" field in the ServerItem tooltip shows both ipv4 and ipv6
addresses. The order of addresses in this field is not determined.
In the wild it is randomized. As discussed in #5696 it is better to implement
a concrete ordering to prevent user confusion. To further improve the
readability of the addresses we split the addresses field in two fields
called "IPv4 address" and "IPv6 address". The ipv4 address is now always
shown above the ipv6 address.
Implements #5696
Co-Authored-By: GuybrushThreepwoodII
Checks