FIX(server,settings,log): announce if settings file is not present #6231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hartmnt
added
client
backport-needed
bug
Krzmbrzl
reviewed
Oct 11, 2023
|
Ah, could you please add You can use rebase to change the commit message (and squash the requested review change into your commit) and then force-push your branch. |
|
Sure thing, if there's one thing i know then its how to rebase :D |
WOLFI3654
force-pushed
the
fix/no-ini-log
branch
from
d6198bc
to
04a85c3
Compare
Apparently, QSettings does not care if the specified settings file exists or not. Therefore, no keys will be loaded into the settings as if the file was empty. We specifically check for the missing file to not reference a ghost file in the logs. Fixes mumble-voip#6077
See mumble-voip#6077 (comment) for more information on why this does nothing useful
WOLFI3654
force-pushed
the
fix/no-ini-log
branch
from
04a85c3
to
c12990b
Compare
|
Should be good to go. Let me know if there is anything else for this |
Krzmbrzl
approved these changes
Oct 11, 2023
Hartmnt
approved these changes
Oct 11, 2023
WOLFI3654
changed the title
|
Thank you for fixing this 👍 |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Krzmbrzl
added a commit
that referenced
this pull request
Oct 26, 2023
…nnounce if settings file is not present"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently, QSettings does not care if the specified settings file exists or not. Therefore, no keys will be loaded into the settings as if the file was empty. We specifically check for the missing file to not reference a ghost file in the logs.
Fixes #6077
Checks