FIX(ui): Preserve other check-box states if All messages was checked #6348
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the 'Messages' settings, when disabling a single notification method for a single message type, all check-boxes will disappear in that column if 'All messages' was checked to begin with. This is because the automatic unchecking of the 'All messages' check-box is treated as if the user actually clicked it. Using a QSignalBlocker before unchecking the 'All messages' fixes the issue Fixes mumble-voip#6302
Hartmnt
approved these changes
Feb 27, 2024
|
Thanks for fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the 'Messages' settings, when disabling a single notification method for a single message type, all check-boxes will disappear in that column if 'All messages' was checked to begin with. This is because the automatic unchecking of the 'All messages' check-box is treated as if the user actually clicked it. Using a
QSignalBlockerbefore unchecking the 'All messages' fixes the issueFixes #6302
Checks