Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setting suggestversion via ICE requires bitmasked version instead of "1.2.4" #989

Closed
mumble-voip opened this issue May 31, 2013 · 1 comment
Closed

setting suggestversion via ICE requires bitmasked version instead of "1.2.4" #989

mumble-voip opened this issue May 31, 2013 · 1 comment
Labels
ice server
Milestone
1.3.0

Comments

@mumble-voip
Copy link
Collaborator

In order to set a suggestversion using ICE you have to set it to the bitmasked version.

For example, to set as 1.2.5 via ICE you need to actually set "66053"

(1 << 16) + (2 << 8) + 5
=> 66053

The mumble.ini expects "1.2.5" which makes it confusing between setting via ICE and setting via the ini.

This ticket has been migrated from sourceforge. It is thus missing some details like original creator etc.
The original is at https://sourceforge.net/p/mumble/bugs/989/ .
@Kissaki
Copy link
Member

Kissaki commented May 31, 2013

On IRC a link to gist with an "Ugly hack to fix suggestversion when set anywhere but the .ini" has been posted yesterday: https://gist.github.com/fwaggle/584cf2a96002af9d0f64

mkrautz added a commit to mkrautz/mumble that referenced this issue Dec 26, 2015
@mkrautz
Murmur: allow both bitmasked version and version string when setting …
dc918c9 
…'suggestversion' via RPC.

This commit changes the logic for setting the 'suggestversion' config
option via RPC to automatically figure out whether the passed-in value
is a bitmasked version or a version string.

If it is a version string, it will convert the version string to the
bitmasked format, which is what is used internally.

Prior to this, 'suggestversion' via RPC only allowed a bitmasked
version. This was confusing users, since the .ini file requires a
a version string.

Fixes mumble-voip#989
@mkrautz mkrautz mentioned this issue Dec 26, 2015
Closed
mkrautz added a commit to mkrautz/mumble that referenced this issue Dec 26, 2015
@mkrautz
Murmur: allow both bitmasked version and version string when setting …
6b8b828 
…'suggestversion' via RPC.

This commit ensures that a 'suggestversion' is always normalized to a
bitmasked version.

Previously, only a bitmasked 'suggestverson' was allowed.

With this commit, 'suggestversion' may now be either a version string,
or a bitmasked integer value representing the version.

The previous behavior was confusing to users, since the murmur.ini
has always used 'suggestversion' with a version string.

Fixes mumble-voip#989
mkrautz added a commit to mkrautz/mumble that referenced this issue Dec 26, 2015
@mkrautz
Murmur: allow both bitmasked version and version string when setting …
870f974 
…'suggestversion' via RPC.

This commit ensures that a 'suggestversion' is always normalized to a
bitmasked version.

Previously, only a bitmasked 'suggestverson' was allowed.

With this commit, 'suggestversion' may now be either a version string,
or a bitmasked integer value representing the version.

The previous behavior was confusing to users, since the murmur.ini
has always used 'suggestversion' with a version string.

Fixes mumble-voip#989
@Hartmnt Hartmnt mentioned this issue Sep 1, 2022
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ice server
Projects
None yet
Milestone
1.3.0
Development

No branches or pull requests
1 participant
@Kissaki