Cast port number as string #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses mumoshu#10 When using RDS secrets the port number is not a string. As a result, the unmarshal fails. Catch this scenario and add the port as a string.
mumoshu
reviewed
May 2, 2019
| install-tools: | ||
| go get github.com/aws/aws-sdk-go/aws/session | ||
| go get github.com/aws/aws-sdk-go/service/secretsmanager | ||
| go get github.com/pkg/errors |
There was a problem hiding this comment.
I'm now wondering why dep didn't catch these dependencies 🤔
mumoshu
approved these changes
May 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #10
When using RDS secrets the port number is not a string. As a result, the
unmarshal fails. Catch this scenario and add the port as a string.
Also add a Makefile target to install required tools to build locally.