Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix querying existing secrets #6

Merged
merged 1 commit into from
May 2, 2019
Merged

Conversation

hhamalai
Copy link
Contributor

@hhamalai hhamalai commented Mar 14, 2019

Querying existing secrets does not find any results when the current is
of type Pod. This causes the updates to fail, as the controller is
trying to create a new secret instead of updating existing. Fixes #7

Querying existing secrets does not find any results when the current is
of type Pod. This causes the updates to fail, as the controller is
trying to create a new secret instead of updating existing.
@hhamalai hhamalai mentioned this pull request Mar 14, 2019
Copy link
Owner

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good catch! Thanks for fixing this @hhamalai ☺️

@mumoshu mumoshu merged commit fea607a into mumoshu:master May 2, 2019
@hhamalai hhamalai deleted the fix-update branch May 2, 2019 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to update secrets
2 participants