Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

platform darwin/arm64 added #2

Merged
merged 3 commits into from
Jan 9, 2022

Conversation

sharjilk
Copy link
Contributor

@sharjilk sharjilk commented Jan 7, 2022

Reference Issues/PRs

darwin/arm64 support

@sharjilk sharjilk marked this pull request as draft January 7, 2022 09:14
@sharjilk sharjilk marked this pull request as ready for review January 7, 2022 09:15
@mumoshu
Copy link
Owner

mumoshu commented Jan 8, 2022

@sharjilk Thanks! This isn't correct in terms of both config and yaml syntaxes. So I've submitted a PR to your branch, which can be found at sharjilk#1.

Would you mind merging it on your fork? Then this pull request will be automatically updated with the change.

Update .krew-release-bot.yaml
@sharjilk
Copy link
Contributor Author

sharjilk commented Jan 9, 2022

thanks @mumoshu I have merged it. Please merge this PR so I can check it.

Copy link
Owner

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution! I think this also needs an update to our workflow that builds release archives so that it includes one for darwin/arm64. I'm going to that in another pr.

@mumoshu mumoshu merged commit 0adc051 into mumoshu:master Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants