Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Play 2.7.0-RC3 and sbt upgrade #68

Merged
merged 4 commits into from
Nov 30, 2018
Merged

Play 2.7.0-RC3 and sbt upgrade #68

merged 4 commits into from
Nov 30, 2018

Conversation

mkurz
Copy link
Contributor

@mkurz mkurz commented Nov 14, 2018

Upgrades to Play 2.7.0-RC3 🎉

Also upgrades sbt to 1.2.x - which mean I had to finally migrate project/Build.scala to build.sbt. (They are very similar however, I cleaned it up a bit).

BTW: Play 2.7.0-RC3 wasn't released for Scala 2.13 yet. That will happen in a future version.

@mkurz mkurz mentioned this pull request Nov 14, 2018
@mkurz
Copy link
Contributor Author

mkurz commented Nov 15, 2018

RC3 has been officially released now: https://discuss.lightbend.com/t/play-2-7-0-rc3-released/2715

@mkurz
Copy link
Contributor Author

mkurz commented Nov 16, 2018

Added two more commits.
@mumoshu Looking forward to your review 😉

@mkurz
Copy link
Contributor Author

mkurz commented Nov 23, 2018

Ping @mumoshu (Please also merge #67, thanks)

@mkurz mkurz closed this Nov 30, 2018
@mkurz mkurz reopened this Nov 30, 2018
Copy link
Owner

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @mkurz! Thanks as always for your continuous support. LGTM.

@mumoshu mumoshu merged commit d3cde4d into mumoshu:master Nov 30, 2018
@mumoshu
Copy link
Owner

mumoshu commented Nov 30, 2018

Im now releasing this for Scala 2.11.12.. Thanks for patience

PLAY_VERSION=2.7.0-RC8 sbt ++2.11.12 publishSigned sonatypeRelease

@mumoshu
Copy link
Owner

mumoshu commented Nov 30, 2018

[error] (scala-sample / publishConfiguration) Repository for publishing is not specified.
[error] (java-sample / publishConfiguration) Repository for publishing is not specified.
[error] (publishConfiguration) Repository for publishing is not specified.
[error] Total time: 57 s, completed 2018/11/30 11:18:11

@mumoshu
Copy link
Owner

mumoshu commented Nov 30, 2018

So running em separately seems to work.

PLAY_VERSION=2.7.0-RC8 sbt ++2.11.12 publishSigned
PLAY_VERSION=2.7.0-RC8 sbt ++2.11.12 sonatypeRelease

@mkurz mkurz deleted the play27RC3 branch November 30, 2018 19:36
@mumoshu
Copy link
Owner

mumoshu commented Nov 30, 2018

And for 2.12.7 too.

PLAY_VERSION=2.7.0-RC8 sbt ++2.12.7 sonatypeRelease

@mumoshu
Copy link
Owner

mumoshu commented Nov 30, 2018

Done publishing.

@mkurz
Copy link
Contributor Author

mkurz commented Nov 30, 2018

Please git-tag the releases, thanks! Maybe we can use https://github.com/sbt/sbt-release in future which can automatically publish and then tag the releases...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants