support runner env #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because in order to use parameters in runner options.
mumoshu
reviewed
Oct 15, 2018
|
|
||
| dockerArgs := []string{} | ||
| for _, v := range c.Volumes { | ||
| dockerArgs = append(dockerArgs, "-v", os.ExpandEnv(v)) |
There was a problem hiding this comment.
Thanks for preserving ExpandEnv here!
As far as I remember, this was necessary to expand the HOME env var contained in the src of volume mount, that is useful for mounting .aws or .ssh on the host machine to the container.
cw-ozaki
commented
Oct 15, 2018
| dockerArgs = append(dockerArgs, "-e", fmt.Sprintf("%s=%s", k, os.ExpandEnv(v))) | ||
| } | ||
| if c.Envfile != "" { | ||
| dockerArgs = append(dockerArgs, "--env-file", os.ExpandEnv(c.Envfile)) |
There was a problem hiding this comment.
I am thinking about specification like $PWD/.env and $HOME/.env as usecase.
There was a problem hiding this comment.
Sounds nice. Thanks for clarifying 👍
cw-ozaki
commented
Oct 15, 2018
| dockerArgs = append(dockerArgs, "-v", os.ExpandEnv(v)) | ||
| } | ||
| for k, v := range c.Env { | ||
| dockerArgs = append(dockerArgs, "-e", fmt.Sprintf("%s=%s", k, os.ExpandEnv(v))) |
There was a problem hiding this comment.
Pass the host's environment variable to docker as a use case.
example:
runner:
image: ...
env:
DOCKER_HOST: $DOCKER_HOST
mumoshu
approved these changes
Oct 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support
runner.envoption.and, We have made it possible to expand environment variables and
autoenvparameters with some runner options.