-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DTREX-587 :: columns descriptions #226
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the AmoraModel before the query job execution
…els` usage with SQLAlchemy's mapper registry
- Materializes columns description - Creates table with a schema inferred from model definition Co-Authored-By: Thúlio Costa <thulio.patriota@stone.com.br>
diogommartins
changed the title
feature/DTREX 587 columns descriptions
DTREX-587 :: columns descriptions
Oct 25, 2022
thulio
reviewed
Oct 25, 2022
@@ -15,9 +15,10 @@ | |||
from amora.utils import list_target_files | |||
|
|||
app = typer.Typer( | |||
pretty_exceptions_enable=False, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙏🏽
thulio
approved these changes
Oct 25, 2022
eduwxyz
approved these changes
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
schema_field_for_column
AmoraModel
before the query job executionamora_model_for_name
. Replaceslist_models
usage with SQLAlchemy's mapper registrymaterialization.materialize