Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DTREX-587 :: columns descriptions #226

Merged
merged 9 commits into from
Oct 25, 2022

Conversation

diogommartins
Copy link
Contributor

@diogommartins diogommartins commented Oct 25, 2022

  • ✨ feat(bigquery): Adds columns descriptions to schema_field_for_column
  • ✨ feat(materialization): Creates a table with the schema inferred from the AmoraModel before the query job execution
  • ✨ feat(models): Refactors amora_model_for_name. Replaces list_models usage with SQLAlchemy's mapper registry
  • 🐛 fix(materialization): Refactors materialization.materialize
  • 🐛 fix(examples): Fixes models schemas
  • 🐛 fix(typer): Removes "pretty" exceptions
  • 🐛 fix(tests): Fixes tests models schemas

@diogommartins diogommartins changed the title feature/DTREX 587 columns descriptions DTREX-587 :: columns descriptions Oct 25, 2022
@diogommartins diogommartins self-assigned this Oct 25, 2022
@@ -15,9 +15,10 @@
from amora.utils import list_target_files

app = typer.Typer(
pretty_exceptions_enable=False,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏🏽

@diogommartins diogommartins merged commit 683ea61 into main Oct 25, 2022
@diogommartins diogommartins deleted the feature/DTREX-587-columns-descriptions branch October 25, 2022 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants