refactor: Refatora descoberta de modelos #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thulio
force-pushed
the
refactor/models-discovery
branch
from
5fd6d5b
to
d929ec9
Compare
thulio
requested review from
diogommartins,
eduwxyz,
lemosflavio and
betowxyz
thulio
changed the title
eduwxyz
previously approved these changes
Oct 27, 2022
thulio
commented
Oct 27, 2022
| @@ -125,4 +125,7 @@ def test_models_import_with_valid_table_reference_and_existing_destination_file_ | |||
|
|
|||
| assert result.exit_code == 0, result.stderr | |||
| assert output_path.read_text() | |||
| import sys | |||
|
|
|||
| sys.path.insert(0, output_path.parent.as_posix()) | |||
There was a problem hiding this comment.
Como esse teste cria um arquivo temporário, esse módulo não está no sys.path
Co-authored-by: Diogo Magalhães Machado <diogommartins.dev@gmail.com>
diogommartins
approved these changes
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AmoraModel.model_file_path()->AmoraModel.path()AmoraModel.target_path(model_file_path)->AmoraModel.target_path()