Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: allow test selection #260

Merged
merged 6 commits into from
Dec 7, 2022
Merged

Feat: allow test selection #260

merged 6 commits into from
Dec 7, 2022

Conversation

betowxyz
Copy link
Contributor

@betowxyz betowxyz commented Dec 1, 2022

Sugestão de feature:

Possibilitar seleção de testes através de argumentos do pytest.

@betowxyz betowxyz marked this pull request as ready for review December 1, 2022 19:31
@thulio
Copy link
Collaborator

thulio commented Dec 1, 2022

Uma opção seria delegar tudo direto pro pytest mesmo:

@app.command(
    context_settings={"allow_extra_args": True, "ignore_unknown_options": True}
)
def test(ctx: typer.Context) -> None:
    """
    Runs tests on data in deployed models. Run this after `amora materialize`
    to ensure that the data state is up-to-date.
    """

    pytest_args = settings.DEFAULT_PYTEST_ARGS + ctx.args
    return_code = pytest.main(pytest_args)

    raise typer.Exit(return_code)

diogommartins
diogommartins previously approved these changes Dec 2, 2022
amora/cli/typer_app.py Outdated Show resolved Hide resolved
@betowxyz betowxyz requested a review from thulio December 6, 2022 20:02
@betowxyz betowxyz merged commit 82ebe2a into main Dec 7, 2022
@betowxyz betowxyz deleted the feat/allow_test_selection branch December 7, 2022 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants