Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adiciona shed como ferramenta de lint #83

Merged
merged 3 commits into from
May 2, 2022
Merged

Adiciona shed como ferramenta de lint #83

merged 3 commits into from
May 2, 2022

Conversation

thulio
Copy link
Collaborator

@thulio thulio commented Apr 28, 2022

  • Adiciona shed
  • Adiciona pre-commit
  • Formata código com shed

@thulio thulio self-assigned this Apr 28, 2022
@thulio thulio changed the title chore/shed Adiciona shed como ferramenta de lint Apr 28, 2022
@thulio thulio added enhancement New feature or request dependencies Pull requests that update a dependency file python Pull requests that update Python code labels Apr 28, 2022
@thulio thulio requested a review from lemosflavio April 28, 2022 19:42
@thulio thulio marked this pull request as ready for review April 28, 2022 19:43
diogommartins
diogommartins reviewed May 2, 2022
View reviewed changes
tests/cli/test_materialize.py
@@ -34,7 +35,7 @@ def test_materialize_without_arguments_and_options(materialize: MagicMock):
assert result.exit_code == 0

tables = sorted(
[str(call[1]["model"].__table__) for call in materialize.call_args_list]
str(call[1]["model"].__table__) for call in materialize.call_args_list
Copy link
Contributor

@diogommartins diogommartins May 2, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Irrelevante mas curioso... aqui ele mudou a implementação @thulio

@diogommartins diogommartins merged commit 321b0f3 into main May 2, 2022
@diogommartins diogommartins deleted the chore/shed branch May 2, 2022 16:19
diogommartins pushed a commit that referenced this pull request May 3, 2022
@thulio @diogommartins
Adiciona shed como ferramenta de lint (#83)
8972c89 
* Adiciona shed

* Adiciona pre-commit

* Formata código
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diogommartins diogommartins diogommartins approved these changes

@lemosflavio lemosflavio Awaiting requested review from lemosflavio

Assignees

@thulio thulio

Labels
dependencies Pull requests that update a dependency file enhancement New feature or request python Pull requests that update Python code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thulio @diogommartins