mysql_connections_per_user: fix for non-alphanumeric symbols in fields #783
Conversation
…lus print real username in label
There was a problem hiding this comment.
Hello n0guest,
thank you for fixing the fieldname handling!
Please take a look at my comments in the code below.
If you feel like cleaning up a bit, you may also want to improve some more details of the plugin:
- change the documentation into the POD style (see plugins/munin/munin_stats_plugins for a good example)
- change the graph_category to "db" (see list of recommended categories)
- improve
test_service: it should always exit with zero - even for "no" cases. Additionally its call (around line 72) looks like the function would return (which is not the case). - add an example graph (see PluginGallery) to the repository
It would be great, if you could fix a few of these issues, as well. But of course, you may also feel free to just fix the fieldname handling.
Thank you!
| @@ -100,6 +100,9 @@ sub print_graph_data() { | |||
| if($print_user eq "root") { | |||
| $print_user = "root_"; | |||
| } | |||
| if ( $print_user =~ /[^A-Za-z0-9]/ ) { | |||
| $print_user =~ s/[^A-Za-z0-9]/_/; | |||
| } | |||
There was a problem hiding this comment.
Please use the perl module "Munin::Plugin" for generating a proper fieldname according to munin's restrictions. Just use clean_fieldname($print_user). This function also handles the "root" exception.
Thus you can avoid duplicate code.
|
@n0guest: did I possibly overwhelm you with my wishlist? :) In case you want to focus on this single issue, then I could also merge your proposal as it is. Just tell me ... |
Nope, you didn't. Just little overwhelmed at work within few last weeks. But i'll try to follow your requests at this week or next. |
|
@n0guest: just a friendly (and patient) reminder ... |
|
Ping? |
|
@n0guest: any news? |
|
I merged you original fix. Feel to improve the other bits of the plugins (mentioned in my first comment), if you feel like ... |
Hi.
This is small fix for a non-alphanumeric symbols in field names plus print real username in label.