Use JSON format to obtain data from 'ceph -s' #927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'ceph -s' text output format strongly depends upon ceph version. Using JSON format to obtain data works across different ceph versions.
|
You were reading my thoughts (from #926) :) Just one detail: please quote |
|
I will add the quotes for Anyway: thank you for preparing this improvement! |
|
Sorry about the quotes for Thank you for accepting the PR :-) |
Thou shalt never feel sorry for contributing! :) |
|
:-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'ceph -s' text output format strongly depends upon ceph version. Using JSON format to obtain data works across different ceph versions.
Execute 'ceph -s' only once to get data