Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/pod maintenance #238

Merged
merged 4 commits into from Jul 20, 2014
Merged

Conversation

ssm
Copy link
Member

@ssm ssm commented Jul 20, 2014

Module::Build has "testcover" "testpod" and "testpodcoverage" targets already. I suggest we use these, instead of writing unit tests to do the same.

This set of commits will:

  • Add targets in top makefile, which again run the */Build files with appropriate options
  • Remove test files which do this already. This removes the "style and documentation" checks from unit tests, which check if the code runs as it should.

ssm added 4 commits July 20, 2014 14:31
 - Missing one "Build"

 - */MANIFEST should also not disappear for each invocation of "make"
 - the tests are already present, but not used by default
Module::Build has functionality for this, so we do not need to repeat this in our unit tests. The
following convenience targets has been added to Makefile already:

 - "make testpod" for POD syntax checs

 - "make testpodcoverage" for POD coverage

 - "make testcover" for test (and POD) coverage.
ssm added a commit that referenced this pull request Jul 20, 2014
@ssm ssm merged commit 88d6c7b into munin-monitoring:devel Jul 20, 2014
@ssm ssm deleted the feature/pod-maintenance branch March 21, 2015 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant