Skip to content

Commit

Permalink
Add support for custom notarization primary-bundle-id
Browse files Browse the repository at this point in the history
  • Loading branch information
MichalMMac committed Jun 13, 2019
1 parent ee6520c commit 2eb8273
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 7 deletions.
13 changes: 7 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -266,12 +266,13 @@ or, in JSON format in a build-info.json file:

Keys/values of the `notarization_info` dictionary:

| Key | Type | Required | Description |
| --------------- | ------- | -------- | ----------- |
| username | String | Yes | Login email adress of your developer Apple ID |
| password | String | Yes | 2FA app specific password. For information about the password and saving it to the login keychain see the web page [Customizing the Notarization Workflow](https://developer.apple.com/documentation/security/notarizing_your_app_before_distribution/customizing_the_notarization_workflow) |
| asc_provider | String | No | Only needed when a user account is associated with multiple providers |
| stapler_timeout | Integer | No | See paragraph bellow |
| Key | Type | Required | Description |
| ----------------- | ------- | -------- | ----------- |
| username | String | Yes | Login email adress of your developer Apple ID |
| password | String | Yes | 2FA app specific password. For information about the password and saving it to the login keychain see the web page [Customizing the Notarization Workflow](https://developer.apple.com/documentation/security/notarizing_your_app_before_distribution/customizing_the_notarization_workflow) |
| asc_provider | String | No | Only needed when a user account is associated with multiple providers |
| primary_bundle_id | String | No | Defaults to `identifier`. `primary_bundle_id` is usefull when `identifier` contains characters such as '_' Apple notary service does not like |
| stapler_timeout | Integer | No | See paragraph bellow |

**About stapling**

Expand Down
5 changes: 4 additions & 1 deletion munkipkg
Original file line number Diff line number Diff line change
Expand Up @@ -673,7 +673,10 @@ def notarize(build_info, options):
'altool',
'--notarize-app',
'--primary-bundle-id',
build_info['identifier'],
build_info['notarization_info'].get(
'primary_bundle_id',
build_info['identifier']
),
'--username',
build_info['notarization_info']['username'],
'--password',
Expand Down

0 comments on commit 2eb8273

Please sign in to comment.